Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the --compatibility flag to cover other defaults #418

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

dralley
Copy link
Contributor

@dralley dralley commented Feb 6, 2024

  • --compatibility will enable sqlite metadata by default
  • --compatibility will leave group metadata uncompressed rather than defaulting to the same compression as everything else

I believe this covers the bases in terms of ensuring createrepo_c 1.0 can still generate repos consumable by ancient RHEL / SUSE without too much effort.

I don't add group_gz (separate gzip-compressed group metadata) back - this is aiming for minimal additional complexity and group_gz simply isn't worth it. It's usually a relatively tiny metadata file anyway.

@dralley
Copy link
Contributor Author

dralley commented Feb 6, 2024

We got a complaint from a user that was using createrepo_c on their Satellite box and of course the default changes messed with them. They're not really supposed to be doing that, but since Koji and others have had the same issue (needing to support EL7 repos using a createrepo_c package from Fedora), we may as well just make it an easy problem to work around.

It's a simple fix in any case.

Copy link
Contributor

@kontura kontura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kontura kontura merged commit 63a9bf5 into rpm-software-management:master Feb 7, 2024
6 checks passed
@dralley dralley deleted the compat branch February 7, 2024 14:04
@dralley
Copy link
Contributor Author

dralley commented Feb 7, 2024

@kontura Could you do a quick release w/ these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants