[spec] Remove /etc/dnf/protected.d/dnf.conf #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2023
|
same note as here then lgtm |
|
Oh actually, since this PR requires rpm-software-management/libdnf#1621, it would be nice to add libdnf's version in the spec file. I would propose to bump both libdnf and dnf's versions and add the minimum requirements in the spec. other than this it looks good to me |
Conan-Kudo
approved these changes
Sep 21, 2023
Instead, hardcode the protection of dnf in libdnf. This way, DNF 5 will be able to uninstall DNF 4. = changelog = msg: Allow dnf to be removed by DNF 5 type: enhancement
Require new version of libdnf so that dnf remains a protected package, see rpm-software-management/libdnf#1621.
evan-goode
force-pushed
the
evan-goode/self-protection
branch
from
051fd22 to
87bd305
Compare
Sounds good, bumped the version. @jan-kolarik would you be able to take a look at this and rpm-software-management/libdnf#1621? I'm not sure what the release workflow is like. |
inknos
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, hardcode the protection of dnf in libdnf. This way, DNF 5 will be able to uninstall DNF 4.
Requires: rpm-software-management/libdnf#1621
Related: rpm-software-management/dnf5#906