automatic: Enhance errors reporting #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-blaha
force-pushed
the
mblaha/automatic-notify-error
branch
from
5db022b to
593ac4b
Compare
|
I made a PR to disable the new test for fedora 41 and higher: rpm-software-management/ci-dnf-stack#1604 |
Emitters must be initialized early to ensure they can report errors that might occur in earlier stages of execution, before transaction resolution. Also a broader range of exceptions must be caught to ensure they are communicated to the user through the configured emitters. For example "No space left on the device" error can be raised during the fill_sack() call. This patch should report it via configured emitters. Resolves: https://issues.redhat.com/browse/RHEL-61882
m-blaha
force-pushed
the
mblaha/automatic-notify-error
branch
from
593ac4b to
bdb9866
Compare
|
The failing tests are unrelated, in my previous PR I disabled the wrong dnf automatic test here is a fix: rpm-software-management/ci-dnf-stack#1607 There are also unrelated rawhide Lets not block this PR on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emitters must be initialized early to ensure they can report errors that might occur in earlier stages of execution, before transaction resolution. Also a broader range of exceptions must be caught to ensure they are communicated to the user through the configured emitters.
For example "No space left on the device" error is raised during the fill_sack() call. This patch should report it via configured emitters.
Resolves: https://issues.redhat.com/browse/RHEL-61882