automatic: Fix incorrect Error class instantiation #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnf.exceptions.Error class constructor accepts only one argument - error message.
|
The failing tests are unrelated, in my previous PR I disabled the wrong dnf automatic test here is a fix: rpm-software-management/ci-dnf-stack#1607 There are also unrelated rawhide copr failing tests, I made an issue for that here: rpm-software-management/ci-dnf-stack#1606 The fix looks good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dnf.exceptions.Error class constructor accepts only one argument - error message.
The error somehow slipped through a gap our CI and the reason is that related tests are not part of the master branch, they are only in RHEL branch.