Trailing spaces in dnf5 stdout

[glum23]

There are trailing spaces in dnf5 stdout describing transactions

      Package                  Arch   Version Repository                     Size          
      Upgrading:                                                                                            
       SuperRipper             x86_64 1.2-1   dnf-ci-thirdparty-updates   0.0   B
         replacing SuperRipper x86_64 1.0-1   dnf-ci-thirdparty           0.0   B

(spaces after Upgrading: till the same position as B in the following line).
It has already broken one step in ci-dnf-stack, see rpm-software-management/ci-dnf-stack#1355
I'd say it can cause problems also with other steps there (e.g. exact matching of outputs) and also with other automatic processing of dnf5 output.

[kontura]

I have briefly looked into it and we would probably have to separate the transaction table into multiple libscols_tables with titles like "Upgrading", "Installing"... so we could scols_symbols_set_title_padding(current_table_symbols, "").

This is because currently the section headers ("Upgrading", "Installing"..) are just normal table lines and if we change their padding symbol it will change on all table lines.

One possible problem is that if multiple tables are used they could end up with not aligned columns.

[m-blaha]

The other option might be using scols_table_print_range(table, first, last) smartcols API and keep the line ranges and headings of sections separately.
It's already used for list command, see

dnf5/libdnf5-cli/output/package_list_sections.cpp

Lines 48 to 66 in 80b06e2

	void PackageListSections::print() {
	// smartcols does not support spanning the text among multiple cells to create
	// heading lines. To create sections, print the headings separately and than print
	// appropriate range of the table.
	bool separator_needed = false;
	for (const auto & [heading, first, last] : sections) {
	if (separator_needed) {
	std::cout << std::endl;
	}
	if (!heading.empty()) {
	std::cout << heading << std::endl;
	}
	scols_table_print_range(table, first, last);
	separator_needed = true;
	}
	if (!sections.empty()) {
	std::cout << std::endl;
	}
	}

[pkratoch]

I think the issue is already resolved. I cannot reproduce it and ci-dnf-stack tests pass when I revert rpm-software-management/ci-dnf-stack@b4dba41 . It looks like this commit fixed it: d4a144d . Therefore, I created a revert of the ci-dnf-stack workaroud rpm-software-management/ci-dnf-stack#1617 and I am closing this issue.