Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust extract_section_content_from_text for dnf5 #1355

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

glum23
Copy link
Contributor

@glum23 glum23 commented Aug 2, 2023

In dnf5 stdout, there can be spaces after some section names (e.g. 'Installing:', 'Upgrading:'). It has broken functionality of the step stdout section "{section}" contains "{regexp}". This change should fix the issue.

@ppisar
Copy link
Contributor

ppisar commented Sep 22, 2023

@glum23, any progress?

@glum23
Copy link
Contributor Author

glum23 commented Sep 25, 2023

@ppisar, from my side it's done. The question is whether dnf5 (see rpm-software-management/dnf5#790 ) will be fixed soon or it would be better to merge this PR.

dnf-behave-tests/dnf/steps/cmd.py Outdated Show resolved Hide resolved
dnf-behave-tests/dnf/steps/cmd.py Outdated Show resolved Hide resolved
dnf-behave-tests/dnf/steps/cmd.py Outdated Show resolved Hide resolved
@pep8speaks
Copy link

pep8speaks commented Oct 24, 2023

Hello @glum23! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2023-10-24 14:19:29 UTC

@glum23 glum23 requested a review from ppisar October 24, 2023 14:32
Copy link
Contributor

@ppisar ppisar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@ppisar ppisar merged commit b4dba41 into rpm-software-management:main Oct 26, 2023
4 checks passed
@glum23 glum23 deleted the work-steps-cmd branch October 30, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants