Throw an error on invalid repo input for setopt and *repo options
#1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. It seems that it's not covered by any CI test so far, we should add them or at least create a follow-up issue. Also please mention the changes in the DNF4 vs DNF5 doc. |
This was referenced Dec 11, 2023
kontura
force-pushed
the
invalid_repo
branch
from
ae03a6a to
e37a6f7
Compare
When later setting repos_from_path as enabled we want to use substituted ids.
This fixes a bug when --repofrompath with variable is diabled by --disablerepo=*
Eg:
`dnf5 repo list --repofrompath=NEW_REPO,THE_PATH --disablerepo=*`
-> NEW_REPO is enabled
but:
`dnf5 repo list --releasever=RLS --repofrompath=NEW_REPO_\${{releasever}},THE_PATH --disablerepo=* `
-> wrongly results in NEW_REPO_RLS being disabled
Options `--setopt`, `--enable-repo`, `--disable-repo` and `--repo` will not accept repo-id vaule that doesn't match any configured repository. This is different to dnf4 where only `--repo` and `--enablerepo` throw an error on invalid repo id. `--disablerepo` just shows a warning and `--setopt` doesn't show any problem. In dnf4 the error also depends on `strict` conf option but this is deprecated in dnf5. dnf5 is strict by default.
kontura
force-pushed
the
invalid_repo
branch
from
e37a6f7 to
ecdb903
Compare
I have made a PR with some tests: rpm-software-management/ci-dnf-stack#1426 Finally I have tweaked the PR a bit, now it should report all problems not just the first one. |
Merged
via the queue into
rpm-software-management:main
with commit Dec 15, 2023
766f0f8
5 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Options
--setopt,--enable-repo,--disable-repoand--repowill not accept repo-id vaule that doesn't match any configured repository.This is different to dnf4 where only
--repoand--enablerepothrow an error on invalid repo id.--disablerepojust shows a warning and--setoptdoesn't show any problem.Closes: #1082