Make protected_packages an append options #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conan-Kudo
previously approved these changes
Jan 4, 2024
It will allow to use configuration overrides from /usr for protected packages. Resolves: rpm-software-management#1107
j-mracek
force-pushed
the
config-protected
branch
from
67799d9 to
0bd9f12
Compare
keszybz
reviewed
Jan 9, 2024
doc/dnf5.conf.5.rst
Outdated
| @@ -373,7 +373,7 @@ repository configuration file should aside from repo ID consists of baseurl, met | |||
| ``protected_packages`` | |||
| :ref:`list <list-label>` | |||
|
|
|||
| List of packages that DNF5 should never completely remove. | |||
| This append list option contains name of packages that DNF5 should never completely remove. | |||
keszybz
reviewed
Jan 9, 2024
Conan-Kudo
approved these changes
Jan 9, 2024
|
@j-mracek should I merge the CI PR first and re-run this? Or merge this and then the CI PR? |
|
@Conan-Kudo I have to fix a typo first. Our CI is broken, therefore we have to run all tests locally. Download ci-dnf-stack project build or download packages with patch to |
j-mracek
force-pushed
the
config-protected
branch
from
0bd9f12 to
1775663
Compare
The set of protected packages might differ between systems therefore it would be good to use a relevant set for the current location.
j-mracek
force-pushed
the
config-protected
branch
from
1775663 to
7aef62a
Compare
Merged
via the queue into
rpm-software-management:main
with commit Jan 18, 2024
0b57dd0
5 of 9 checks passed
yuwata
pushed a commit
to yuwata/systemd-fedora
that referenced
this pull request
Oct 14, 2024
uapi-group/specifications#76 Actually, add a new file under /usr, but keep the old file in /etc because it's still needed for dnf. The new file in the new location is useful because it means that we get the correct behaviour even when /etc is emptied (on systems with new dnf version). dnf5 reads the new location: rpm-software-management/dnf5#1107 rpm-software-management/dnf5#1110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will allow to use configuration overrides from /usr for protected packages.
Resolves: #1107
CI: rpm-software-management/ci-dnf-stack#1431