Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README with updated coprs #976

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Update README with updated coprs #976

merged 1 commit into from
Nov 3, 2023

Conversation

inknos
Copy link
Collaborator

@inknos inknos commented Oct 16, 2023

Doc updates relates to fedora version being released soon and to these changes in our nightly builds:
rpm-software-management/ci-dnf-stack#1396
rpm-software-management/ci-dnf-stack#1394

@inknos inknos requested a review from evan-goode October 16, 2023 15:00
ppisar
ppisar reviewed Oct 16, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@inknos inknos force-pushed the update-readme-with-updated-coprs branch from 25d3814 to c09e5a4 Compare October 16, 2023 15:25
@ppisar ppisar self-assigned this Oct 16, 2023
evan-goode
evan-goode requested changes Oct 16, 2023
View reviewed changes
Copy link
Member

@evan-goode evan-goode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, I suggest writing a README/description for https://copr.fedorainfracloud.org/coprs/rpmsoftwaremanagement/dnf5-testing-nightly before merging.

README.md Outdated Show resolved Hide resolved
@evan-goode
Copy link
Member

A caveat to recommending F37 users install DNF 5 via the dnf-nightly Copr: the next time they dnf upgrade, they'll upgrade to the nightly builds of DNF 4 also, which may be unexpected.

@inknos
Copy link
Collaborator Author

inknos commented Oct 17, 2023

Thanks for all the comments, I will update the pr now

@inknos inknos force-pushed the update-readme-with-updated-coprs branch from c09e5a4 to 1bc1888 Compare October 17, 2023 11:31
@inknos
Copy link
Collaborator Author

inknos commented Oct 17, 2023

Looks good overall, I suggest writing a README/description for https://copr.fedorainfracloud.org/coprs/rpmsoftwaremanagement/dnf5-testing-nightly before merging.

I updated the description in copr. @evan-goode , do you think we should also provide a description upstream?

@evan-goode
Copy link
Member

Looks good overall, I suggest writing a README/description for https://copr.fedorainfracloud.org/coprs/rpmsoftwaremanagement/dnf5-testing-nightly before merging.

I updated the description in copr. @evan-goode , do you think we should also provide a description upstream?

A description in Copr is what I meant, LGTM!

@inknos inknos added this pull request to the merge queue Nov 3, 2023
Merged via the queue into rpm-software-management:main with commit e4a131b Nov 3, 2023
7 checks passed
@inknos inknos deleted the update-readme-with-updated-coprs branch November 3, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisar ppisar ppisar left review comments

@evan-goode evan-goode evan-goode approved these changes

Assignees

@ppisar ppisar

Labels
None yet
Projects
DNF team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inknos @evan-goode @ppisar