Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transaction: Save the reason for installing #1628

Merged

Conversation

aleasto
Copy link
Contributor

@aleasto aleasto commented Sep 30, 2023

It doesn't make sense to look for the reason in the history, as the package is not installed yet.
We can get the reason of a package being installed from hawkey.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1733274

@aleasto
Copy link
Contributor Author

aleasto commented Sep 30, 2023

State of things before this change:

dnf/dnf5 install PackageKit install
PackageKit remove Removes deps Removes deps
dnf/dnf5 remove Removes deps Doesn't remove deps

I have no idea how PackageKit install × PackageKit remove can work without this change. The reason info must be duplicated somewhere else.

It doesn't make sense to look for the reason in the history, as the
package is not installed yet.
We can get the reason of a package being installed from hawkey.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1733274
@aleasto
Copy link
Contributor Author

aleasto commented Sep 30, 2023

@Conan-Kudo Conan-Kudo merged commit 00a2cad into rpm-software-management:dnf-4-master Sep 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants