Replace assert by map_grow #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will make code prepared for situation when number of solvables is increased after query is created and applied. The issue can be easilly triggered by adding remote RPMs therefore the patch fixes a standard situation Resolves: https://issues.redhat.com/browse/RHEL-27657
|
The code looks good. |
Yes, I have a PR to fix also the |
|
This PR cannot modify any result of our CI - I already discussed possibility of CI test with our QE and there is only one option - beaker and Eva agreed that she will provide it. API test are supported only for DNF5 branch. The issue is not reproducible with DNF5. |
|
@j-mracek Oh, I see. We are good to go then. |
m-blaha
approved these changes
Mar 6, 2024
m-blaha
merged commit ef8ac7f
into
rpm-software-management:dnf-4-master
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will make code prepared for situation when number of solvables is increased after query is created and applied.
The issue can be easilly triggered by adding remote RPMs therefore the patch fixes a standard situation
Resolves: https://issues.redhat.com/browse/RHEL-27657