Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virtual destructor to TransactionItem #1648

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions libdnf/transaction/TransactionItem.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ namespace libdnf {

class TransactionItemBase {
public:
virtual ~TransactionItemBase() = default;

ItemPtr getItem() const noexcept { return item; }
void setItem(ItemPtr value) { item = value; }

Expand Down Expand Up @@ -101,6 +103,7 @@ class TransactionItem : public TransactionItemBase {
explicit TransactionItem(Transaction *trans);

TransactionItem(SQLite3Ptr conn, int64_t transID);
virtual ~TransactionItem() = default;

int64_t getId() const noexcept { return id; }
void setId(int64_t value) { id = value; }
Expand Down
Loading