MergedTransaction: Fix invalid memory access when dropping items #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrohel
reviewed
Apr 24, 2024
When an item is dropped from the merged transaction, the `ItemPair` reference becomes invalid and should no longer be used.
jan-kolarik
force-pushed
the
jkolarik/fix-merge-transaction-on-item-erase
branch
from
9a345da to
bea285c
Compare
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an item is dropped from the merged transaction, the
previousItemPairreference becomes invalid and should no longer be used.Related: #1644, rpm-software-management/dnf#2031
Closes: #1652.