Since we use rpmtsAddReinstallElement rpm also uninstalls the package #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It calls callbacks for `RPMCALLBACK_INST_START` and `RPMCALLBACK_INST_PROGRESS` just like before when the reinstall was done through regural install (rpmtsAddInstallElement) but in addition it also calls `RPMCALLBACK_UNINST_START` and `RPMCALLBACK_UNINST_PROGRESS`. To ensure they find the `DnfPackage` add it to `remove_helper` array. Unfortunaly this means that the reinstall action is reported twice to the clients (one install and one uninstall). We could try to hide one of the them but I think a better solution is to report what is actually happening and report one install and one uninstall. This is for the context part of libdnf (microdnf, packagekit, ...) Fixes: rpm-software-management#1653
kontura
force-pushed
the
reinstall_callbacks
branch
from
19f358f to
60c328f
Compare
Does this mean that the package is mentioned twice in the transaction table? |
It looks like this: Before instead of: there was just: |
That looks fine, thanks for the example! |
jan-kolarik
approved these changes
May 15, 2024
jan-kolarik
merged commit bc37168
into
rpm-software-management:dnf-4-master
9 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It calls callbacks for
RPMCALLBACK_INST_STARTandRPMCALLBACK_INST_PROGRESSjust like before when the reinstall was done through regural install (rpmtsAddInstallElement) but in addition it also callsRPMCALLBACK_UNINST_STARTandRPMCALLBACK_UNINST_PROGRESS. To ensure they find theDnfPackageadd it toremove_helperarray.Unfortunaly this means that the reinstall action is reported twice to the clients (one install and one uninstall). We could try to hide one of the them but I think a better solution is to report what is actually happening and report one install and one uninstall.
Fixes: #1653
This is for the context part of libdnf (microdnf, packagekit, ...)