Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set pool flag to fix pool_addfileprovides_queue() without filelists.xml #1670

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

kontura
Copy link
Contributor

@kontura kontura commented Jun 25, 2024

Since dnf4 now also conditionally load filelists it ran into the same problem as dnf5 here: rpm-software-management/dnf5#520

Additional details in: openSUSE/libsolv#531

Backported test: rpm-software-management/ci-dnf-stack#1517

kontura added a commit to kontura/ci-dnf-stack that referenced this pull request Jun 25, 2024
Since dnf4 now also conditionally load filelists it ran into the
same problem as dnf5 here: For: rpm-software-management/dnf5#520
Backport the test.

For: rpm-software-management/libdnf#1670
Since dnf4 now also conditionally load filelists it ran into the same
problem as dnf5 here: rpm-software-management/dnf5#520

Additional details in: openSUSE/libsolv#531
@ppisar ppisar self-assigned this Jul 2, 2024
Copy link
Contributor

@ppisar ppisar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. It builds.

The tests failure on Fedora 41 is because of a broken "dnf5 copr" command.

I tested manually that it correctly uses filelists downloaded after building libsolv cache.

@ppisar ppisar merged commit a6d89d6 into rpm-software-management:dnf-4-master Jul 2, 2024
8 of 9 checks passed
ppisar pushed a commit to rpm-software-management/ci-dnf-stack that referenced this pull request Jul 2, 2024
Since dnf4 now also conditionally load filelists it ran into the
same problem as dnf5 here: For: rpm-software-management/dnf5#520
Backport the test.

For: rpm-software-management/libdnf#1670
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants