Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set POOL_FLAG_ADDFILEPROVIDESFILTERED only when not loading filelists #1675

Merged

Conversation

kontura
Copy link
Contributor

@kontura kontura commented Oct 1, 2024

It is set in dnf_sack_load_repo which means its done for each repo, this is not needed, it would be sufficient to set the flag only once. However there is a ready access to whether filelists are loaded and the call pool_set_flag is very cheap.

Any alternatives I could see would probably require extending the API which seems unnecessary.

For #1674

It is set in `dnf_sack_load_repo` which means its done for each repo,
this is not needed, it would be sufficient to set the flag only once.
However there is a ready access to whether filelists are loaded and the
call `pool_set_flag` is very cheap.

Any alternatives I could see would probably require extending the API
which seems unnecessary.
@m-blaha m-blaha self-assigned this Oct 3, 2024
Copy link
Member

@m-blaha m-blaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to my tests, the performance drop is gone. Thank you!

@m-blaha m-blaha merged commit cd51f57 into rpm-software-management:dnf-4-master Oct 4, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants