Better naming of the cache directory #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is microdnf, not yum. Normal dnf uses /var/cache/dnf. It is not a good idea to reuse it. But there is no need to use /var/cache/yum, at least in ROSA where this package did not exist before. Naming cache directory as "microdnf" allows to own it properly in the RPM package.
|
I'm not sure we wouldn't want to use the |
|
Are any locks made to prevent parallel usage of it by dnf and microdnf? |
kontura
reviewed
Jun 16, 2021
There was a problem hiding this comment.
There are locks but I think microdnf doesn't use the same code as dnf for caching. Even the contents of /var/cache/yum and /var/cache/dnf look different so I don't think we can easily share the cache.
Because of that I feel we shouldn't mix both types of cache in the same directory.
Maybe we could leave such a change for dnf5?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is microdnf, not yum.
Normal dnf uses /var/cache/dnf. It is not a good idea to reuse it.
But there is no need to use /var/cache/yum, at least in ROSA where this package did not exist before.
Naming cache directory as "microdnf" allows to own it properly in the RPM package.
[ this pull request is a suggestion, I am not sure that you will want to change location on the fly, breaking compatibility ]