Unskip stuff

rrousselGit · Mar 14, 2024 · a82e1c1 · a82e1c1
1 parent fa99b20
commit a82e1c1
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 34 deletions.
diff --git a/packages/riverpod/test/new/core/ref_test.dart b/packages/riverpod/test/new/core/ref_test.dart
@@ -2606,26 +2606,22 @@ void main() {
         verifyZeroInteractions(listener);
       });
 
-      test(
-        'is not called when using container.read (autoDispose)',
-        skip: true,
-        () async {
-          final container = ProviderContainer.test();
-          final listener = OnCancelMock();
-          final dispose = OnDisposeMock();
-          final provider = StateProvider.autoDispose((ref) {
-            ref.keepAlive();
-            ref.onCancel(listener.call);
-            ref.onDispose(dispose.call);
-          });
+      test('is not called when using container.read (autoDispose)', () async {
+        final container = ProviderContainer.test();
+        final listener = OnCancelMock();
+        final dispose = OnDisposeMock();
+        final provider = StateProvider.autoDispose((ref) {
+          ref.keepAlive();
+          ref.onCancel(listener.call);
+          ref.onDispose(dispose.call);
+        });
 
-          container.read(provider);
-          await container.pump();
+        container.read(provider);
+        await container.pump();
 
-          verifyZeroInteractions(listener);
-          verifyZeroInteractions(dispose);
-        },
-      );
+        verifyZeroInteractions(listener);
+        verifyZeroInteractions(dispose);
+      });
 
       test('listeners are cleared on rebuild', () {
         final container = ProviderContainer.test();
@@ -2804,12 +2800,6 @@ void main() {
         expect(buildCount, 1);
         verifyNoMoreInteractions(onDispose);
       });
-
-      test(
-        'once a provider was disposed, cannot add more listeners until it is rebuilt',
-        () {},
-        skip: 'TODO',
-      );
     });
 
     group('mounted', () {

diff --git a/packages/riverpod/test/new/providers/notifier_test.dart b/packages/riverpod/test/new/providers/notifier_test.dart
@@ -498,12 +498,6 @@ void main() {
       verifyOnly(listener, listener(Equal(42), Equal(21)));
     });
 
-    test(
-      'can override the Notifier with a matching custom implementation',
-      () {},
-      skip: 'TODO',
-    );
-
     test('can override Notifier.build', () {});
 
     if (factory.isAutoDispose) {

diff --git a/packages/riverpod/test/old/framework/provider_element_test.dart b/packages/riverpod/test/old/framework/provider_element_test.dart
@@ -158,8 +158,6 @@ void main() {
         ]),
       );
     });
-
-    test('include ref.read dependents', () {}, skip: true);
   });
 
   group('hasListeners', () {

diff --git a/packages/riverpod/test/old/framework/ref_watch_test.dart b/packages/riverpod/test/old/framework/ref_watch_test.dart
@@ -107,8 +107,6 @@ void main() {
     expect(buildCount, 2);
   });
 
-  test('when selector throws, rebuild providers', () {}, skip: true);
-
   test('on provider that threw, exceptions bypass the selector', () {
     final container = ProviderContainer.test();
     final dep = Provider<int>((ref) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -158,8 +158,6 @@ void main() { @@
             ]),
           );
         });
-        test('include ref.read dependents', () {}, skip: true);
       });
       group('hasListeners', () {
@@ Expand Down @@