Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Korean[ko] translation #3299

Merged
merged 8 commits into from
Jan 26, 2024
Merged

Conversation

MinByeongDon
Copy link
Contributor

@MinByeongDon MinByeongDon commented Jan 25, 2024

This PR is Korean(ko) translation for following:

  • site

Introduction

  • Why Riverpod?
  • Getting started

Riverpod for Providers users

  • Quickstart
  • Provider vs Riverpod
  • Motivation

Essentials

  • Make your first provider/network request
  • Performing side effects
  • Passing arguments to your requests
  • Websockets and synchronous execution
  • Combining requests
  • Clearing cache and reacting to state disposal
  • Eager initialization of providers
  • Testing your providers
  • Logging and error reporting
  • FAQ
  • DO/DON'T

Case studies

  • Pull to refresh
  • Debouncing/Cancelling network requests

Advanced topics

  • Optimizing performance

Concepts

  • About code generation
  • About hooks

Migration guides

  • From StateNotifier
  • From ChangeNotifier
  • ^0.14.0 to ^1.0.0
  • ^0.13.0 to ^0.14.0

Thanks

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (56fe8e6) 95.16% compared to head (61c2cef) 95.16%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3299   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files          53       53           
  Lines        2295     2295           
=======================================
  Hits         2184     2184           
  Misses        111      111           

@rrousselGit
Copy link
Owner

Hello! Thanks for this :)

Make sure to run code-generators to update generated code

@MinByeongDon
Copy link
Contributor Author

MinByeongDon commented Jan 25, 2024

@rrousselGit
Thanks for kind comment.
One of the two fails was resolved after "update generated code".

But the other fail is not related to the translation work, so I don't know how to solve it.
I've seen tests that failed in CI builds pass correctly in my local environment.
(expected and actual are the same in my local env.)

But, in Github CI build, below test failed; Any ideas on how to fix this?

@MinByeongDon
Copy link
Contributor Author

The last commit 61c2cef is a additional translation of:

  • ^0.14.0 to ^1.0.0.mdx
  • ^0.13.0 to ^0.14.0.mdx

@rrousselGit
Copy link
Owner

Lint tests failing are unrelated indeed. I need to fix those myself, don't worry about it.

LGTM!

@rrousselGit rrousselGit merged commit cc75825 into rrousselGit:master Jan 26, 2024
42 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants