Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve adopted styles from nodes being removed when virtual dom is in use #1641

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

megboehlert
Copy link

@megboehlert megboehlert commented Jan 31, 2025

All node removals and additions happen before adopted style sheets are applied when using virtual dom so when a removed node contains a stylesheet that an added node relies on, that node will not be styled properly because the styles did not get stored in the styleMirror.

verify-issue-and-fix-adopted-styles.mp4

Copy link

changeset-bot bot commented Jan 31, 2025

🦋 Changeset detected

Latest commit: 28463d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
rrweb Major
@rrweb/types Major
@rrweb/rrweb-plugin-canvas-webrtc-record Major
@rrweb/rrweb-plugin-canvas-webrtc-replay Major
@rrweb/rrweb-plugin-console-record Major
@rrweb/rrweb-plugin-console-replay Major
@rrweb/rrweb-plugin-sequential-id-record Major
@rrweb/rrweb-plugin-sequential-id-replay Major
rrweb-snapshot Major
rrdom Major
rrdom-nodejs Major
rrweb-player Major
@rrweb/all Major
@rrweb/replay Major
@rrweb/record Major
@rrweb/packer Major
@rrweb/utils Major
@rrweb/web-extension Major
rrvideo Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@megboehlert megboehlert changed the title preserve adopted styles from nodes being removed when virtual dom is in use fix: preserve adopted styles from nodes being removed when virtual dom is in use Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant