Replace deprecated convert_to_dataset() with time_as_observations()
#410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasperVanDenBosch
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Great, thanks @qian-chu this looks good. I'll let @HeikoSchuett decide whether we merge this now or later this week since we're planning for the next release.
|
Thank you @qian-chu . This is certainly a sensible change and I don't seem any reason to wait. I'll merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TemporalDataset.convert_to_dataset()method got deprecated and replaced byTemporalDataset.time_as_observations()in #295. Yetconvert_to_dataset()was still called on several occasions includingcalc_rdm_movie()and tests and demos. I replaced all such occurances to avoid triggering warnings.