-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setup.py #12
Update setup.py #12
Conversation
specify encodings in `open` function.
Hey, dear rsalmei, like I said in this issue before, conda-forge is a platform; what I will do is just submitting this package to conda-forge, you are still the maintainer to the conda-forge package repo (like this one), which is created by conda-forge, not by me. |
@rsalmei ping |
Sorry, I haven't seen this before. Merged. |
Oh, do I have to also publish it to PyPI @Brainor, or just merge it is enough? |
Oh, it's OK now. I closed the PR because I used the patch in the conda-forge feedstock to modify the If you are interested in maintaining the conda-forge package aside from the PyPI one, all you need to do is to become the maintainer of the about-time-feedstock repo . According to the manual, just opening an issue in the feedstock repository with the following title: I've also proposed the |
That's excellent, thank you 👍 I love messages like yours, full of links so one can go deeper if needed. I did enter them all, but I know nothing about conda, mamba, or feedstocks, so I think I'll let them to people like you, who knows what he is doing... Thanks for the alive-progress one as well! |
Oh thank you:) I'm also totally new to the feedstock thing, I just learn this stuff to make |
While I trying to submit this package to conda-forge, the checks threw an error.
I guess it's about the encoding in reading file; according to document, the encoding used in Windows system is
cp936
in China, notutf-8
; but theREADME.md
file contains emoji characters, which can't be read withcp936
encoding.Could you please update the pypi package if it's OK with you? 😱