-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RSKIP432 #432
base: master
Are you sure you want to change the base?
Add RSKIP432 #432
Conversation
description: | ||
status: Draft | ||
purpose: Usa | ||
author: (@rmoreliovlabs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be "RM" and add you to the README file as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you included RM in the README but we also use initials here
| :------------ |:-------------| | ||
|**Title** |RbtcSwap| | ||
|**Created** |MAY-2024 | | ||
|**Author** |@rmoreliovlabs | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as before
@@ -0,0 +1,69 @@ | |||
--- | |||
rskip: 432 | |||
title: RbtcSwap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a little bit more descriptive name? Something like "Add new RBTCSwap contract"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about the name RbtcSwap mechanism
? This feature is not a new contract, but an implementation of a mechanisim that uses an existing contact
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it's a hardcoded bytecode contract that you invoke how ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if it got confusing, what I meant is that this RSKIP is not only to add the contract but also the mechanism that allows the claim to be paid after its execution.
No description provided.