Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RSKIP432 #432

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add RSKIP432 #432

wants to merge 5 commits into from

Conversation

rmoreliovlabs
Copy link

No description provided.

@rmoreliovlabs rmoreliovlabs changed the title Add RSKIP for EthSwap proposal Add RSKIP for RbtcSwap proposal May 24, 2024
@rmoreliovlabs rmoreliovlabs changed the title Add RSKIP for RbtcSwap proposal Add RSKIP432 May 24, 2024
description:
status: Draft
purpose: Usa
author: (@rmoreliovlabs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "RM" and add you to the README file as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you included RM in the README but we also use initials here

| :------------ |:-------------|
|**Title** |RbtcSwap|
|**Created** |MAY-2024 |
|**Author** |@rmoreliovlabs |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before

@@ -0,0 +1,69 @@
---
rskip: 432
title: RbtcSwap
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a little bit more descriptive name? Something like "Add new RBTCSwap contract"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about the name RbtcSwap mechanism? This feature is not a new contract, but an implementation of a mechanisim that uses an existing contact

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it's a hardcoded bytecode contract that you invoke how ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if it got confusing, what I meant is that this RSKIP is not only to add the contract but also the mechanism that allows the claim to be paid after its execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants