Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US-1972 RIF Wallet - Android crashes when opening the wallet #801

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

TravellerOnTheRun
Copy link
Collaborator

Can you guys try your Android devices with this PR to see the load time? It's a pretty simple change, I want to create something more sophisticated to improve performance, but i see improvements even with these changes on my android emulator.

Copy link
Contributor

@jormelCoin jormelCoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the guys but I faced this behavior:

So that I was unable to proceed with the tests

20231108_111629.mp4

@TravellerOnTheRun
Copy link
Collaborator Author

I don't know the guys but I faced this behavior:

So that I was unable to proceed with the tests

20231108_111629.mp4

Try again, please

Copy link
Contributor

@jormelCoin jormelCoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the build from scratch and I see It still happens.

20231109_110458.mp4

@TravellerOnTheRun
Copy link
Collaborator Author

I did the build from scratch and I see It still happens.

20231109_110458.mp4

oh, you mean the crash... okay, I will try to improve futher

@jessgusclark jessgusclark added the dont merge Do not merge this PR label Nov 17, 2023
@jessgusclark
Copy link
Member

I am marking this as do not merge as the ticket is blocked in Jira. We are waiting on improvements between the server and the app before this task continues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked dont merge Do not merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants