Resolve Issue 1416 #1512
Merged
Resolve Issue 1416 #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the footnote mark is NA, no footnote mark is printed in LaTeX (which matches the behavior in HTML). Previously the footnote mark was printed as "NA"
Removes footnote marks equal to NA from 3 existing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When creating tables in LaTeX, if there are multiple footnotes, footnotes without an explicit superscript are preceded by "\textsuperscript{NA}" when rendered. This pull request removes these NAs.
The change replaces a series of
paste0calls with calls to a new function,sprintf_unless_na, that returns an NA_character_ when an NA is passed to the function. (I switched frompaste0tosprintfbecause it's slightly more streamlined -- usingpaste0would have required three arguments be passed each time.)The existing tests are sufficient to cover this pull request, though the snapshots for three tests have to be modified to show results without NA's preceding the unnumbered footnotes. Those modifications are included in the pull request.
I'm assuming this is a
Related GitHub Issues and PRs
Checklist
testthatunit tests totests/testthatfor any new functionality.Fixes: #1416