Support factors in fmt_markdown()
with HTML output
#1883
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes #1882 by ensuring factors are converted to text before converting to markdown when
fmt_markdown()
is used with HTML output. It achieves this by addingtext <- as.character(text)
as the first step in themd()
function. It also adds a test of rendering a factor column with markdown formatting and updates the NEWS file.Created on 2024-09-17 with reprex v2.1.0
Related GitHub Issues and PRs
fmt_markdown()
on a factor prints the numeric factor level when the output format is HTML #1882Checklist
testthat
unit tests totests/testthat
for any new functionality.