fix bookdown::html_document2 cross-ref #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@nielsbock I verified that the captions still work with pdf documents.
In #1800, there was
I suspect this was required to make it work with LaTeX?
Therefore, I just branched it and make gt emit a different string whether latex or not.
Verified that the example in the linked issue renders in both bookdown::html_document2 and bookdown::pdf_document2.
(edit: pkgdown CI failure unrelated)
Related GitHub Issues and PRs
Checklist
testthatunit tests totests/testthatfor any new functionality.