Overhaul the notion of a bespoke FIPS-140 mode #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adopts Go 1.24's native `fips140.Enabled()` support to make runtime algorithm choices and formally deprecates its own `FIPSMode`. In the process the module also gets significantly less complex: we no longer use build tags and conditional compilation to identify FIPS builds, and several internal APIs no longer return errors as a result. The `--version` flag now also reports whether FIPS mode is enabled. And we now build special `rskey-fips` binaries and Linux packages against the Go Cryptographic Module, too. Additonal unit tests are included. We also specifically test the code against the Go Cryptographic Module to ensure compliance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adopts Go 1.24's native
fips140.Enabled()support to make runtime algorithm choices and formally deprecates its ownFIPSMode.In the process the module also gets significantly less complex: we no longer use build tags and conditional compilation to identify FIPS builds, and several internal APIs no longer return errors as a result.
The
--versionflag now also reports whether FIPS mode is enabled.And we now build special
rskey-fipsbinaries and Linux packages against the Go Cryptographic Module, too.Additonal unit tests are included. We also specifically test the code against the Go Cryptographic Module to ensure compliance.
Closes #2.