Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove propTypes #514

Merged
merged 1 commit into from
Dec 25, 2024
Merged

refactor: remove propTypes #514

merged 1 commit into from
Dec 25, 2024

Conversation

simonguo
Copy link
Member

@simonguo simonguo commented Dec 25, 2024

This pull request includes several changes across various files to update dependencies, remove prop-types, and clean up code. The most important changes include updating dependencies in package.json and pnpm-lock.yaml, removing prop-types from multiple components, and replacing react-is with custom utility functions.

Dependency Updates:

  • Updated @rsuite/icons to version 1.3.0 in package.json and pnpm-lock.yaml [1] [2].
  • Updated peer dependencies for react and react-dom to version 18 in package.json.

Removal of prop-types:

  • Removed prop-types from src/Cell.tsx, src/Column.tsx, src/ColumnGroup.tsx, src/HeaderCell.tsx, and src/Table.tsx [1] [2] [3] [4] [5].

Code Cleanup:

  • Removed react-is and replaced it with custom utility functions in src/Table.tsx and src/utils/children.ts [1] [2].
  • Cleaned up karma.conf.js by removing an unnecessary blank line.

These changes help modernize the codebase, reduce dependencies, and improve maintainability.

Copy link

vercel bot commented Dec 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-table ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 25, 2024 7:53am

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@simonguo simonguo merged commit 30b4bfc into next Dec 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant