-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update SnapWP environment variables #57
Conversation
…o fix/update-env-vars
@justlevine / @Ta5r Does this approach look good? If yes, I'll update the tests next. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick first pass re the formatting and to get some clarification about your commented
approach.
Pinged @Ta5r to review and assist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some cleanup + formatting changes in my last commit, accidentally invalidating @Ta5r 's tests 😬.
Fix those tests (again, apologies) and this should be ready to merge
No worries, we'll fix the tests. |
… into fix/update-env-vars
@justlevine This PR is now ready for a final review/merge. |
What
This PR updates the env variables shown in the admin panel.
Why
Currently snapwp-helper uses outdated env variables.

They need to be what's expected in our starter: https://github.com/rtCamp/headless/blob/develop/frontend/examples/nextjs/starter/.env.example
Related Issue(s):
How
The missing variables are added to the VariableRegistry, and the old ones updated.
A
commented
property is added to the variables, which is used to determine if the variable declaration line is commented in the env file preview shown in the admin panel.Testing Instructions
Go to GraphQL > SnapWP in the WordPress admin panel.
Screenshots
Additional Info
Checklist