Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat : backporting populate pattern inner blocks #33

Closed
wants to merge 1 commit into from

Conversation

Ta5r
Copy link
Collaborator

@Ta5r Ta5r commented Dec 17, 2024

What you did in this PR ?

Back ported functionality to resolve and populate innerBlocks for core/pattern blocks and included a test to verify pattern inner block resolution.

Why is it necessary ?

To ensure core/pattern blocks can correctly resolve and include their nested blocks.

How ?

  • Back ported populate_pattern_inner_blocks to resolve pattern blocks using resolve_pattern_blocks.
  • Added an integration test to validate block resolution for patterns in both flat and nested contexts.
  • Registered and unregistered a test block pattern to simulate the functionality.

Tasks :

  • Backport populate pattern inner blocks.
  • Add codeception unit test

@Ta5r Ta5r self-assigned this Dec 17, 2024
@Ta5r Ta5r marked this pull request as ready for review December 17, 2024 08:20
@Ta5r Ta5r requested a review from justlevine December 17, 2024 10:59
@justlevine justlevine force-pushed the feat/backporting_populate_pattern_inner_blocks branch from 0450d2b to d57adbf Compare December 17, 2024 17:33
Copy link
Collaborator

@justlevine justlevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 tracking in wpengine#323

Note: I added a changeset and cleaned up the commit history since the last round of merges showed they dont have the best hygiene upstream.

@justlevine
Copy link
Collaborator

Merged upstream 🚀

@justlevine justlevine closed this Dec 18, 2024
@justlevine justlevine deleted the feat/backporting_populate_pattern_inner_blocks branch December 18, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants