options: expand to handle more than 3 frequency indices #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give an option for pos1-frequency to be up to 6 frequency indices, adding values 5, and 6. Expand the SNR masks to 6 frequency indices, up from 3, adding pos1-snrmask_L6, pos1-snrmask_L7, and pos1-snrmask_L8 (just to follow existing sequence). Expand the eratio parameters to 6 frequency indices, up from 3, adding stats-eratio6, stats-eratio7, stats-eratio8 (just to follow existing sequence).
Also the SNR might not have been copied to the processing options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were the bare minimum option additions for more than 3 frequencies. The naming of these options does not seem great, the L6 and L7 and L8, but it's workable and something is needed. Without a SNR mask and eratio the extra signals are not really usable.
Give an option for pos1-frequency to be up to 6 frequency indices, adding values 5, and 6.
Expand the SNR masks to 6 frequency indices, up from 3, adding pos1-snrmask_L6, pos1-snrmask_L7, and pos1-snrmask_L8 (just to follow existing sequence).
Expand the eratio parameters to 6 frequency indices, up from 3, adding stats-eratio6, stats-eratio7, stats-eratio8 (just to follow existing sequence).