Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtkpos: rework the rolling exclusion of satellites #535

Open
wants to merge 1 commit into
base: demo5
Choose a base branch
from

Conversation

ourairquality
Copy link

The heuristics in manage_amb_LAMBDA() select a rolling satellite to test for exclusion, to see if it improves the ambiguity ratio. This was intending to note the sats used for AR, but was also iterating over the frequencies and noting sat/freq used for AR, but the array to hold the sat mapping was only large enough for the sats, not sats*freqs, leading to OOB access when there were many observations and frequencies. It was rolling over this combination, not as intended. Further it was sensitive to changes in the set of sats used for AR, the rolling point could jump around, jump back, and not progress smoothly thought the set of sats. Rework to address these issues, to roll through that sats smoothly.

Could have addressed the OOB along by increasing arsats[]. Guessing that the bumbling roll was not an unintended key heuristic, that fixing this will be an improvement.

The heuristics in manage_amb_LAMBDA() select a rolling satellite to
test for exclusion, to see if it improves the ambiguity ratio. This
was intending to note the sats used for AR, but was also iterating
over the frequencies and noting sat/freq used for AR, but the array to
hold the sat mapping was only large enough for the sats, not
sats*freqs, leading to OOB access when there were many observations
and frequencies. It was rolling over this combination, not as
intended. Further it was sensitive to changes in the set of sats used
for AR, the rolling point could jump around, jump back, and not
progress smoothly thought the set of sats. Rework to address these
issues, to roll through that sats smoothly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant