Correct the accounting of outgoing RPC fragment sizes #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For outgoing fragmented RPC messages, the header size was accounted for an extra time for each fragment except the first one. This change corrects that.
pyhys
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
This is about receiving an ACK on a fragment we have sent earlier, and the calculation of how much data we have successfully sent so far. For the first ACK we should count the entire message, but for consecutive messages we should only count the payload (not the header).
Change an error message to be slightly more helpful.
|
Perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For outgoing fragmented RPC messages, the header size was accounted for an extra time for each fragment except the first one. This change corrects that.