Lock LWIP before p-net linkoutput call #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also mention that this PR fixes #548. Looks great otherwise! |
VictorSkoglund
force-pushed
the
lock_tcpip
branch
2 times, most recently
from
1e109f8 to
2a3c1c3
Compare
hefloryd
reviewed
May 22, 2023
| @@ -12,9 +12,6 @@ stack: | |||
| - Fix SNMP ifDescr in ifTable. | |||
| - Discard invalid UDP packets. | |||
| - VLAN tag support. | |||
| - Lock mutex while handling received frame | |||
There was a problem hiding this comment.
Should not remove this. LWIP_TCPIP_CORE_LOCKING_INPUT is still being set.
Should however remove "Lock mutex for Tx..." for dwmac1000.c and dwgmac1000.c as it has been removed.
This commit fixes rtlabs-com#548. The xemacps descriptor queues are becoming corrupt, due to both lwip and p-net using the same driver but p-net does not check if the driver is busy. To resolve the issue, the LWIP core needs to be locked before it is called by p-net.
VictorSkoglund
force-pushed
the
lock_tcpip
branch
from
2a3c1c3 to
6b0c56b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for xemacps descriptor queues becomeing corrupt, due to both lwip and p-net using the same driver but p-net does not check if the driver is busy. To resolve the issue, the LWIP core needs to be locked before it is called by p-net.