Skip to content

Commit

Permalink
Fix xplat/endtoend/jest-e2e/apps/facebook_xplat/ReactNativeCoreE2E/__…
Browse files Browse the repository at this point in the history
…tests__/Border-corner-radii-elevation-percentages-e2e.js to actually use the right example (facebook#44525)

Summary:
Pull Request resolved: facebook#44525

These examples were added, but their names were duplicated. This caused our internal e2e tests to accidentally target the wrong examples.

Changelog:
[General][Fixed] RNTester examples for border percentages are now properly covered by E2E screenshot tests.

Reviewed By: NickGerleman

Differential Revision: D57207306

fbshipit-source-id: 32ed5cc6b136a8928b11afe8b824c752edcdd9e5
  • Loading branch information
GijsWeterings authored and facebook-github-bot committed May 10, 2024
1 parent 01afb08 commit 143e310
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
16 changes: 8 additions & 8 deletions packages/rn-tester/js/examples/Border/BorderExample.js
Original file line number Diff line number Diff line change
Expand Up @@ -126,9 +126,9 @@ const styles = StyleSheet.create({
},
border9Percentages: {
borderWidth: 10,
borderTopLeftRadius: '10%',
borderBottomRightRadius: '20%',
borderColor: 'black',
borderTopLeftRadius: '20%',
borderBottomRightRadius: '10%',
borderColor: 'red',
},
border10: {
borderWidth: 10,
Expand All @@ -141,9 +141,9 @@ const styles = StyleSheet.create({
border10Percentages: {
borderWidth: 10,
backgroundColor: 'white',
borderTopLeftRadius: '10%',
borderBottomRightRadius: '20%',
borderColor: 'black',
borderTopLeftRadius: '20%',
borderBottomRightRadius: '10%',
borderColor: 'red',
elevation: 10,
},
border11: {
Expand Down Expand Up @@ -359,7 +359,7 @@ export default ({
},
{
title: 'Corner Radii (Percentages)',
name: 'corner-radii',
name: 'corner-radii-percentages',
description: 'borderTopLeftRadius & borderBottomRightRadius',
render: function (): React.Node {
return (
Expand All @@ -386,7 +386,7 @@ export default ({
},
{
title: 'Corner Radii / Elevation (Percentages)',
name: 'corner-radii-elevation',
name: 'corner-radii-elevation-percentages',
description: 'borderTopLeftRadius & borderBottomRightRadius & elevation',
platform: 'android',
render: function (): React.Node {
Expand Down
2 changes: 1 addition & 1 deletion packages/rn-tester/js/examples/View/ViewExample.js
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ export default ({
},
{
title: 'Rounded Borders (Percentages)',
name: 'rounded-borders-percentage',
name: 'rounded-borders-percentages',
render(): React.Node {
return (
<View
Expand Down

0 comments on commit 143e310

Please sign in to comment.