Do not impose scroll limits when configuring alignments manually

rubensousa · Aug 28, 2024 · 17c184f · 17c184f
1 parent c10c28f
commit 17c184f
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 2 deletions.
diff --git a/...idTest/kotlin/com/rubensousa/dpadrecyclerview/test/tests/alignment/AlignmentLookupTest.kt b/...idTest/kotlin/com/rubensousa/dpadrecyclerview/test/tests/alignment/AlignmentLookupTest.kt
@@ -21,7 +21,6 @@ import com.google.common.truth.Truth.assertThat
 import com.rubensousa.dpadrecyclerview.AlignmentLookup
 import com.rubensousa.dpadrecyclerview.ChildAlignment
 import com.rubensousa.dpadrecyclerview.ParentAlignment
-import com.rubensousa.dpadrecyclerview.ParentAlignment.Edge
 import com.rubensousa.dpadrecyclerview.test.TestLayoutConfiguration
 import com.rubensousa.dpadrecyclerview.test.helpers.getItemViewBounds
 import com.rubensousa.dpadrecyclerview.test.helpers.getRecyclerViewBounds
@@ -44,7 +43,7 @@ class AlignmentLookupTest : DpadRecyclerViewTest() {
             spans = 1,
             orientation = RecyclerView.VERTICAL,
             parentAlignment = ParentAlignment(
-                edge = Edge.MIN_MAX,
+                edge = ParentAlignment.Edge.MIN_MAX,
                 offset = 0,
                 fraction = 0f
             ),
@@ -147,4 +146,44 @@ class AlignmentLookupTest : DpadRecyclerViewTest() {
         }
     }
 
+    @Test
+    fun testScrollIsStillAppliedAfterFastScrolling() {
+        // given
+        launchFragment()
+        val bottomParentAlignment = ParentAlignment(fraction = 1f)
+        val bottomChildAlignment = ChildAlignment(fraction = 1f)
+        val recyclerViewBounds = getRecyclerViewBounds()
+
+        onRecyclerView("Set alignment") { recyclerView ->
+            recyclerView.setAlignmentLookup(object : AlignmentLookup {
+                override fun getParentAlignment(
+                    viewHolder: RecyclerView.ViewHolder,
+                ): ParentAlignment? {
+                    if (viewHolder.layoutPosition == 0) {
+                        return bottomParentAlignment
+                    }
+                    return null
+                }
+
+                override fun getChildAlignment(viewHolder: RecyclerView.ViewHolder): ChildAlignment? {
+                    if (viewHolder.layoutPosition == 0) {
+                        return bottomChildAlignment
+                    }
+                    return null
+                }
+            })
+        }
+        waitForLayout()
+
+        // when
+        KeyEvents.pressDown(times = 10)
+        waitForIdleScrollState()
+        KeyEvents.pressUp(times = 10)
+        waitForIdleScrollState()
+
+        // then
+        val viewBounds = getItemViewBounds(position = 0)
+        assertThat(viewBounds.bottom).isEqualTo(recyclerViewBounds.bottom)
+    }
+
 }
diff --git a/.../src/main/java/com/rubensousa/dpadrecyclerview/layoutmanager/alignment/LayoutAlignment.kt b/.../src/main/java/com/rubensousa/dpadrecyclerview/layoutmanager/alignment/LayoutAlignment.kt
@@ -216,6 +216,14 @@ internal class LayoutAlignment(
         if (itemCount == 0) {
             return
         }
+        /**
+         * Client wants to specify the alignments manually,
+         * so we shouldn't impose any scroll limits
+         */
+        if (alignmentLookup != null) {
+            parentAlignmentCalculator.invalidateScrollLimits()
+            return
+        }
         val endAdapterPos: Int
         val startAdapterPos: Int
         val endLayoutPos: Int