Merge pull request #237 from rubensousa/viewholder_animations

Cancel animations in onViewDetachedFromWindow since they prevent ViewHolders from being recycled
rubensousa · Jul 10, 2024 · b630502 · b630502
2 parents 2150cf5 + 33166f9
commit b630502
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/...java/com/rubensousa/dpadrecyclerview/sample/ui/screen/compose/NestedComposeListAdapter.kt b/...java/com/rubensousa/dpadrecyclerview/sample/ui/screen/compose/NestedComposeListAdapter.kt
@@ -59,6 +59,10 @@ class NestedComposeListAdapter(
         holder.item?.let {
             scrollState.save(holder.getRecyclerView(), it.diffId)
         }
+    }
+
+    override fun onViewDetachedFromWindow(holder: NestedComposeListViewHolder) {
+        super.onViewDetachedFromWindow(holder)
         holder.cancelAnimations()
     }
 

diff --git a/.../main/java/com/rubensousa/dpadrecyclerview/sample/ui/screen/list/HorizontalListAdapter.kt b/.../main/java/com/rubensousa/dpadrecyclerview/sample/ui/screen/list/HorizontalListAdapter.kt
@@ -80,4 +80,8 @@ class HorizontalListAdapter(
         holder.recycle()
     }
 
+    override fun onViewDetachedFromWindow(holder: HorizontalListViewHolder) {
+        holder.cancelAnimations()
+    }
+
 }
diff --git a/...in/java/com/rubensousa/dpadrecyclerview/sample/ui/screen/list/HorizontalListViewHolder.kt b/...in/java/com/rubensousa/dpadrecyclerview/sample/ui/screen/list/HorizontalListViewHolder.kt
@@ -82,6 +82,10 @@ class HorizontalListViewHolder(
         animator.startDeselectionAnimation()
     }
 
+    fun cancelAnimations() {
+        animator.cancel()
+    }
+
     override fun getSubPositionAlignments(): List<SubPositionAlignment> {
         return alignments
     }