-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #195 from rubensousa/compose_focus
Send focus to composables now that view-interop is fixed
- Loading branch information
Showing
27 changed files
with
959 additions
and
281 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
160 changes: 160 additions & 0 deletions
160
...ndroidTest/java/com/rubensousa/dpadrecyclerview/compose/DpadComposeFocusViewHolderTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,160 @@ | ||
| /* | ||
| * Copyright 2023 Rúben Sousa | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.rubensousa.dpadrecyclerview.compose | ||
|
|
||
| import androidx.compose.ui.test.SemanticsMatcher | ||
| import androidx.compose.ui.test.assert | ||
| import androidx.compose.ui.test.assertIsDisplayed | ||
| import androidx.compose.ui.test.assertIsNotDisplayed | ||
| import androidx.compose.ui.test.junit4.createAndroidComposeRule | ||
| import androidx.compose.ui.test.onNodeWithText | ||
| import androidx.recyclerview.widget.RecyclerView | ||
| import androidx.test.espresso.Espresso | ||
| import androidx.test.espresso.Espresso.onView | ||
| import androidx.test.espresso.matcher.ViewMatchers | ||
| import com.google.common.truth.Truth.assertThat | ||
| import com.rubensousa.dpadrecyclerview.DpadRecyclerView | ||
| import com.rubensousa.dpadrecyclerview.ExtraLayoutSpaceStrategy | ||
| import com.rubensousa.dpadrecyclerview.testfixtures.recording.ScreenRecorderRule | ||
| import com.rubensousa.dpadrecyclerview.testing.KeyEvents | ||
| import com.rubensousa.dpadrecyclerview.testing.actions.DpadRecyclerViewActions | ||
| import com.rubensousa.dpadrecyclerview.testing.rules.DisableIdleTimeoutRule | ||
| import org.junit.Rule | ||
| import org.junit.Test | ||
|
|
||
| class DpadComposeFocusViewHolderTest { | ||
|
|
||
| @get:Rule | ||
| val idleTimeoutRule = DisableIdleTimeoutRule() | ||
|
|
||
| @get:Rule | ||
| val screenRecorderRule = ScreenRecorderRule() | ||
|
|
||
| @get:Rule | ||
| val composeTestRule = createAndroidComposeRule<ComposeFocusTestActivity>() | ||
|
|
||
| @Test | ||
| fun testComposeItemsReceiveFocus() { | ||
| assertFocus(item = 0, isFocused = true) | ||
| assertSelection(item = 0, isSelected = true) | ||
|
|
||
| KeyEvents.pressDown() | ||
| waitForIdleScroll() | ||
|
|
||
| assertFocus(item = 1, isFocused = true) | ||
| assertSelection(item = 1, isSelected = true) | ||
| } | ||
|
|
||
| @Test | ||
| fun testComposeFocusChanges() { | ||
| composeTestRule.activityRule.scenario.onActivity { activity -> | ||
| activity.clearFocus() | ||
| } | ||
|
|
||
| Espresso.onIdle() | ||
| assertFocus(item = 0, isFocused = false) | ||
| assertSelection(item = 0, isSelected = true) | ||
|
|
||
| composeTestRule.activityRule.scenario.onActivity { activity -> | ||
| activity.requestFocus() | ||
| } | ||
|
|
||
| assertFocus(item = 0, isFocused = true) | ||
| assertSelection(item = 0, isSelected = true) | ||
| } | ||
|
|
||
| @Test | ||
| fun testClicksAreDispatched() { | ||
| // given | ||
| var clicks: List<Int> = emptyList() | ||
| composeTestRule.activityRule.scenario.onActivity { activity -> | ||
| clicks = activity.getClicks() | ||
| } | ||
|
|
||
| // when | ||
| KeyEvents.click() | ||
|
|
||
| // then | ||
| assertThat(clicks).isEqualTo(listOf(0)) | ||
| } | ||
|
|
||
| @Test | ||
| fun testCompositionIsClearedWhenClearingAdapter() { | ||
| val viewHolders = ArrayList<RecyclerView.ViewHolder>() | ||
| composeTestRule.activityRule.scenario.onActivity { activity -> | ||
| viewHolders.addAll(activity.getViewsHolders()) | ||
| activity.removeAdapter() | ||
| } | ||
|
|
||
| viewHolders.forEach { viewHolder -> | ||
| val composeView = viewHolder.itemView as DpadComposeView | ||
| assertThat(composeView.hasComposition()).isFalse() | ||
| } | ||
| composeTestRule.onNodeWithText("0").assertDoesNotExist() | ||
| } | ||
|
|
||
| @Test | ||
| fun testCompositionIsNotClearedWhenDetachingFromWindow() { | ||
| composeTestRule.activityRule.scenario.onActivity { activity -> | ||
| activity.getRecyclerView().setExtraLayoutSpaceStrategy(object : ExtraLayoutSpaceStrategy { | ||
| override fun calculateStartExtraLayoutSpace(state: RecyclerView.State): Int { | ||
| return 1080 | ||
| } | ||
| }) | ||
| } | ||
| repeat(3) { | ||
| KeyEvents.pressDown() | ||
| waitForIdleScroll() | ||
| } | ||
|
|
||
| composeTestRule.onNodeWithText("0").assertExists() | ||
| composeTestRule.onNodeWithText("0").assertIsNotDisplayed() | ||
| } | ||
|
|
||
| @Test | ||
| fun testCompositionIsClearedWhenViewHolderIsRecycled() { | ||
| repeat(10) { | ||
| KeyEvents.pressDown() | ||
| waitForIdleScroll() | ||
| } | ||
|
|
||
| composeTestRule.onNodeWithText("0").assertDoesNotExist() | ||
|
|
||
| var disposals: List<Int> = emptyList() | ||
| composeTestRule.activityRule.scenario.onActivity { activity -> | ||
| disposals = activity.getDisposals() | ||
| } | ||
|
|
||
| assertThat(disposals).contains(0) | ||
| } | ||
|
|
||
| private fun waitForIdleScroll() { | ||
| onView(ViewMatchers.isAssignableFrom(DpadRecyclerView::class.java)) | ||
| .perform(DpadRecyclerViewActions.waitForIdleScroll()) | ||
| } | ||
|
|
||
| private fun assertFocus(item: Int, isFocused: Boolean) { | ||
| composeTestRule.onNodeWithText(item.toString()).assertIsDisplayed() | ||
| .assert(SemanticsMatcher.expectValue(TestComposable.focusedKey, isFocused)) | ||
| } | ||
|
|
||
| private fun assertSelection(item: Int, isSelected: Boolean) { | ||
| composeTestRule.onNodeWithText(item.toString()).assertIsDisplayed() | ||
| .assert(SemanticsMatcher.expectValue(TestComposable.selectedKey, isSelected)) | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.