Skip to content

fix: check value is a string in isSimpleTermDefinitionPrefix #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

jeswr
Copy link
Contributor

@jeswr jeswr commented Oct 11, 2023

Fixes the spec test error seen in rubensworks/jsonld-streaming-parser.js#113.

@rubensworks note that an observation here is that since #65 we are now normalizing

{
  "@version": 1.1,
  "@protected": true,
  "term": null
}

as

{
  "@version": 1.1,
  "term": {
    "@id": null,
    "@protected": true,
  }
}

which I'm not sure is correct...

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6488780797

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6478874410: 0.0%
Covered Lines: 543
Relevant Lines: 543

💛 - Coveralls

@rubensworks rubensworks merged commit 6a725bd into rubensworks:master Oct 12, 2023
@rubensworks
Copy link
Owner

Thanks!

@rubensworks
Copy link
Owner

Released as 2.3.3.

@jeswr jeswr deleted the fix/check-value-type branch October 12, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants