This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
2377 - 3 #299
Open
2377 - 3 #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 1, 2018
2377/3/sinatra/azure_api.rb
Outdated
| end | ||
|
|
||
| def documents(comment) | ||
| { 'documents': [{ 'id' => '1', 'language' => 'ru', 'text' => comment.comment.to_s }] } |
There was a problem hiding this comment.
Lint/Syntax: unexpected token tCOLON
Lint/Syntax: unexpected token tRCURLY
2377/3/sinatra/azure_api.rb
Outdated
| comment.update score: convert((JSON response.body)['documents'][0]['score']) | ||
| end | ||
|
|
||
| def convert(value) |
There was a problem hiding this comment.
UtilityFunction: TextAnalytics#convert doesn't depend on instance state (maybe move it to another class?). More info.
houndci-bot
reviewed
Aug 1, 2018
| @uri = URI('https://westeurope.api.cognitive.microsoft.com/text/analytics/v2.0/sentiment') | ||
| end | ||
|
|
||
| def analyse(comment) |
There was a problem hiding this comment.
Metrics/AbcSize: Assignment Branch Condition size for analyse is too high. [15.03/15]
|
Let's start with RESTful routes.
|
houndci-bot
reviewed
Aug 2, 2018
2377/3/sinatra/app.rb
Outdated
|
|
||
| get '/clear' do | ||
| Ohm.redis.call('FLUSHALL') | ||
| #erb :active_page |
There was a problem hiding this comment.
Layout/LeadingCommentSpace: Missing space after #.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Номер
2377
Номер задания
3
Ссылка на видео с демо
https://youtu.be/VnCZ9ONpfvg
Комментарии
Хотел сделать то-то, но не успел и не понимаю.