Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NOTE tag from Rails/RedundantActiveRecordAllMethod description for readability #1185

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Remove NOTE tag from Rails/RedundantActiveRecordAllMethod description for readability #1185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/rubocop/cop/rails/redundant_active_record_all_method.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ def allowed_receivers

# Detect redundant `all` used as a receiver for Active Record query methods.
#
# NOTE: For the methods `delete_all` and `destroy_all`,
# this cop will only check cases where the receiver is a model.
# For the methods `delete_all` and `destroy_all`, this cop will only check cases where the receiver is a model.
# It will ignore cases where the receiver is an association (e.g., `user.articles.all.delete_all`).
# This is because omitting `all` from an association changes the methods
# from `ActiveRecord::Relation` to `ActiveRecord::Associations::CollectionProxy`,
Expand Down