Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mutex_m as a runtime dependancy | Run CI against Ruby head #1034

Conversation

joshuay03
Copy link

Context: puma/puma#3320

@joshuay03 joshuay03 force-pushed the add-mutex-m-as-runtime-dep branch from 8a2f6cb to f30ac60 Compare January 17, 2024 23:38
@eregon
Copy link
Collaborator

eregon commented Jan 18, 2024

As you can see https://github.com/ruby-concurrency/concurrent-ruby/actions/runs/7563147565/job/20594974217?pr=1034 is successful.
concurrent-ruby doesn't depend on mutex_m anymore in the latest release and since #1013.

@eregon
Copy link
Collaborator

eregon commented Jan 18, 2024

I'm +1 to add ruby-head in CI though.

@eregon
Copy link
Collaborator

eregon commented Jan 18, 2024

But it's already tested in https://github.com/ruby-concurrency/concurrent-ruby/blob/master/.github/workflows/experimental.yml example run so then I think it's safe to close this.

@eregon eregon closed this Jan 18, 2024
@joshuay03 joshuay03 deleted the add-mutex-m-as-runtime-dep branch January 18, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants