enable_frozen_string_literal in CI #2558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericproulx
force-pushed
the
enable_frozen_string_literal_ci
branch
2 times, most recently
from
449d02b to
8cea3dc
Compare
ericproulx
force-pushed
the
enable_frozen_string_literal_ci
branch
from
8cea3dc to
5d079f4
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR enables Ruby's frozen string literal flag in CI to align the CI environment with the local Docker setup.
- Updates CHANGELOG.md to document the new frozen_string_literal setting.
- Adjusts the CI workflows in test.yml and edge.yml to include RUBYOPT flags for enabling frozen_string_literal.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CHANGELOG.md | Added a changelog entry to document the new CI configuration. |
| .github/workflows/test.yml | Updated the test command to enable frozen string literals using RUBYOPT. |
| .github/workflows/edge.yml | Updated the edge workflow to enable frozen string literals in the test command. |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
dblock
approved these changes
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will enable
frozen_string_literalat Ruby's level when running CI. It's already done locally through the our Docker setup but I thought it would be great to also have it in the CI.Inspired from this gist