[WIP] Algo group's solution collector #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huytd
reviewed
May 28, 2018
solution_collector/src/main.rs
Outdated
| .repo(&repo) | ||
| .pulls() | ||
| .number(pull["number"].as_str().unwrap()) | ||
| .merge() |
There was a problem hiding this comment.
Thường thì sau khi merge một PR phải đi kèm theo cả bước fetch & pull để update lại working copy, hoặc nếu thông qua API như trên web thì cũng phải chờ phía server update, nên thực hiện liên tục như này liệu có dễ bị API call fail ko?
There was a problem hiding this comment.
Your suggestion is to add sleep here?
huytd
reviewed
May 28, 2018
solution_collector/src/main.rs
Outdated
| } | ||
|
|
||
| fn main() -> Result<(), Box<Error>> { | ||
| let token = env::var("GITHUB_TOKEN").expect("GITHUB_TOKEN is not set"); |
There was a problem hiding this comment.
Sao ko push luôn example env file lên luôn
There was a problem hiding this comment.
:omg: cái này set tay thôi.
huytd
approved these changes
Jun 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.