Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Week Report feature #877

Merged
merged 5 commits into from
Aug 22, 2018
Merged

Implement Week Report feature #877

merged 5 commits into from
Aug 22, 2018

Conversation

huytd
Copy link
Collaborator

@huytd huytd commented Jul 31, 2018

Closed #819

@huytd huytd self-assigned this Jul 31, 2018
@huytd huytd requested a review from unrealhoang July 31, 2018 04:51

for (parsing_week, summary) in summaries.iter_mut() {
if *parsing_week == week {
summary.sort_by_key(|pr| pr.entries.iter().filter(|entry| entry.done).count());
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not implement Entry Ranking yet, PRs are welcome.

Copy link
Collaborator

@unrealhoang unrealhoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@huytd huytd merged commit 127f2e8 into master Aug 22, 2018
@huytd huytd deleted the compare-participant-list branch August 22, 2018 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants