Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar rules to make the epilogue declaration optional in the parser input #654

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Grammar rules to make the epilogue declaration optional in the parser input #654

wants to merge 1 commit into from
+420 −406

Conversation

ydah
Copy link
Member

@ydah ydah commented Mar 18, 2025 

diff --git a/lib/lrama/grammar/stdlib.y b/lib/lrama/grammar/stdlib.y
index fc20e0a0d0..b6196d91c3 100644
--- a/lib/lrama/grammar/stdlib.y
+++ b/lib/lrama/grammar/stdlib.y
@@ -116,7 +116,3 @@
  */
 %rule separated_list(separator, X): option(separated_nonempty_list(separator, X))
                                   ;
-
-%%
-
-%union{};

@ydah ydah changed the title Refactor grammar rules to make the epilogue declaration optional in the parser input Grammar rules to make the epilogue declaration optional in the parser input Mar 18, 2025
@ydah
Grammar rules to make the epilogue declaration optional in the parser…
f109739 
… input

```diff
diff --git a/lib/lrama/grammar/stdlib.y b/lib/lrama/grammar/stdlib.y
index fc20e0a0d0..b6196d91c3 100644
--- a/lib/lrama/grammar/stdlib.y
+++ b/lib/lrama/grammar/stdlib.y
@@ -116,7 +116,3 @@
  */
 %rule separated_list(separator, X): option(separated_nonempty_list(separator, X))
                                   ;
-
-%%
-
-%union{};
```
@ydah ydah force-pushed the can-remove-%%-union branch from f6dab85 to f109739 Compare March 18, 2025 14:49
@yui-knk
Copy link
Collaborator

yui-knk commented Mar 20, 2025

Do we need to take care of "template/bison/_yacc.h" if union is nullable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ydah @yui-knk