Freeze some constants to improve Ractor compatibility #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freeze `Net::HTTP::SSL_IVNAMES`, `Net::HTTPResponse::CODE_CLASS_TO_OBJ`
and `Net::HTTPResponse::CODE_TO_OBJ` to improve Ractor compatibility.
This change allows the following code to work:
Ractor.new {
uri = URI.parse('http://example.com')
http = Net::HTTP.new(uri.host, uri.port)
http.open_timeout = nil
http.read_timeout = nil
http.get('/index.html')
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Freeze
Net::HTTP::SSL_IVNAMES,Net::HTTPResponse::CODE_CLASS_TO_OBJandNet::HTTPResponse::CODE_TO_OBJto improve Ractor compatibility.This change allows the following code to work:
Possibilities are that this patch breaks code which modify these constants. I have quickly skimmed over GitHub Code Search and have found only one instance where
CODE_TO_OBJis mutated, from 17-year-old code:https://github.com/tolsen/rubydav/blob/62776abc293073da894b08c22d76952c918525c6/lib/rubydav/webdav.rb#L267
rubydavalready needs a number of modifications to run under Ruby 3.4.1 even without this patch, so I think this change won't introduce additional major damage.