Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup memcheck job #3185

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Speedup memcheck job #3185

merged 1 commit into from
Oct 17, 2024

Conversation

eregon
Copy link
Member

@eregon eregon commented Oct 17, 2024

cc @peterzhu2118

@eregon eregon requested a review from kddnewton October 17, 2024 19:39
@eregon eregon marked this pull request as ready for review October 17, 2024 19:39
@eregon eregon force-pushed the speedup-memcheck-job branch from 448f973 to aaf2438 Compare October 17, 2024 19:41
* By using ubuntu-24.04 which has a recent enough valgrind: #3182 (comment)
@eregon eregon force-pushed the speedup-memcheck-job branch from aaf2438 to 89fd84f Compare October 17, 2024 19:44
@eregon
Copy link
Member Author

eregon commented Oct 17, 2024

Success: https://github.com/ruby/prism/actions/runs/11391934879/job/31696848683?pr=3185 took 6min 23s and this older build https://github.com/ruby/prism/actions/runs/11369080496/job/31625692265 took 9min 24s.

@kddnewton kddnewton merged commit 73555ec into main Oct 17, 2024
54 checks passed
@kddnewton kddnewton deleted the speedup-memcheck-job branch October 17, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants