Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI improvements #34

Merged
merged 4 commits into from
Nov 6, 2024
Merged

CLI improvements #34

merged 4 commits into from
Nov 6, 2024

Conversation

perryqh
Copy link
Contributor

@perryqh perryqh commented Nov 6, 2024

Aliases

Added short aliases to all of the commands.

  • f - for-file
  • g - generate
  • v - validate
  • gv - generate-and-validate

Bug fix

generate-and-validate was printing

"CODEOWNERS out of date. Run codeowners generate to update the CODEOWNERS file".

This is a bug because generate was run just before validation. The source of the bug is that the in-memory representation of CODEOWNERS was stale. The fix is to not run the codowners file validation as it necessarily must be up to date. This has an added performance benefit!

@perryqh perryqh requested a review from tstannard November 6, 2024 02:31
@perryqh perryqh enabled auto-merge (squash) November 6, 2024 02:57
@perryqh perryqh disabled auto-merge November 6, 2024 14:51
Copy link
Contributor

@jackboberg jackboberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@perryqh perryqh enabled auto-merge (squash) November 6, 2024 14:58
@perryqh perryqh disabled auto-merge November 6, 2024 15:08
@perryqh perryqh merged commit 50b7d05 into main Nov 6, 2024
9 checks passed
@perryqh perryqh deleted the gep/cli-improvements branch November 10, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants